Re: [PATCH 1/1] cpu: create stop machine in disable_nonboot_cpus

From: Heiko Carstens
Date: Wed Jan 07 2009 - 11:01:27 EST


On Wed, Jan 07, 2009 at 04:39:15PM +0100, Jiri Slaby wrote:
> Commit
> 772cd49cfa4002439b16dd6b553a11771ac096fd
> (stop_machine: introduce stop_machine_create/destroy.)
> introduced stop_machine_create/destroy, but omitted to call them from
> disable_nonboot_cpus (it's called only from cpu_down).
>
> Create and destroy the stop machine even in disable_nonboot_cpus
> (which calls _cpu_down too) to avoid NULL-pointer dereference oops on
> suspend.
>
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Yep, it's exactly the same what I had as well:

http://lkml.org/lkml/2009/1/7/67

Thanks ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/