Re: [RESEND][RFC PATCH v2] waitfd
From: Davide Libenzi
Date: Wed Jan 07 2009 - 12:53:21 EST
On Wed, 7 Jan 2009, Oleg Nesterov wrote:
> minor nit...
>
> Please note that unlike other sys_...fd() syscalls, sys_waitfd()
> doesn't allow to pass O_CLOEXEC. Looks like we need a separate
> "flags" argument...
I said this even during the first post. Not a minor nit unless we want to
have a sys_waitfd2 soon after.
> Also, ioctl(FIONBIO) or fcntl(O_NONBLOCK) have no effect on
> waitfd, not very good.
Ack.
> I'd suggest to remove WNOHANG from waitfd_ctx->ops and treat
> (->f_flags & O_NONBLOCK) as WNOHANG.
Ack.
> (can't resist, ->ops is not the best name ;)
Ack. "flags" looks a pretty nice shot at it.
- Davide
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/