Re: [PATCH] [TRIVIAL] linux/types.h: Don't depend on __GNUC__ for__le64 / __be64 [synced to git]

From: H. Peter Anvin
Date: Wed Jan 07 2009 - 14:21:42 EST


Detlef Riekenberg wrote:
Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc.
(__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

There is no reason to restrict the typedefs to __GNUC__.
This Patch is trivial for gcc and icc, but required for other compiler.

As reference, the typedefs for __u64 and __s64 where fixed to be
available for other compiler on 02. Mai 2008 by H. Peter Anvin
(commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)

Wine: http://www.winehq.org
pcc: http://pcc.ludd.ltu.se

This patch is again a resync to current git.
Is there anything, that I can do for this Patch?


For what it's worth...

Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

This isn't an x86 thing so it's a bit out of scope for me to push it through -tip, but it's a valid bugfix.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/