Re: [PATCH] IB: check for memory allocation failure [v2]

[Niels de Vos]

Eugene Teo wrote:
> On Thu, Jan 8, 2009 at 10:05 PM, Niels de Vos
> <niels.devos@xxxxxxxxxxxxxxxxxx> wrote:
>> Hi Eugene,
>>
>> please see below.
> 
> Thanks for reviewing. Here's an updated patch:
> 
> Fix error-path NULL deref in c2_register_device().
> 
> Signed-off-by: Eugene Teo <eugeneteo@xxxxxxxxxx>

(note: your patch was attached, not inlined...)

There is also an additional kfree() at the end of the patch. It wasn't
included in the first version you sent. Looks correct now imho.

Reviewed-by: Niels de Vos <niels.devos@xxxxxxxxxxxxxxxxxx>


> ---
>  drivers/infiniband/hw/amso1100/c2_provider.c |   17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)

Attachment: signature.asc
Description: OpenPGP digital signature