Re: x86: meaning of nolapic command line option

From: Ingo Molnar
Date: Sat Jan 10 2009 - 21:48:32 EST



* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> Shouldn't that option imply that all APIC related activity, including
> that relating to IO-APICs or PCI MSI, should be circumvented? I'm
> finding that MSI must be disabled separately, and while most of the
> IO-APIC stuff is indeed not happening, acpi_get_override_irq() only
> checks skip_ioapic_setup, but that doesn't normally set without the
> noapic command line option.
>
> Is there any reason pci_no_msi() and disable_ioapic_setup() shouldn't be
> called when !cpu_has_apic at the end of identify_cpu()?

Yes, both depend on a lapic and they might limp on with whatever the BIOS
gave us, you are right that it should be disabled explicitly. Mind sending
a patch?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/