Re: linux-next: Tree for January 12 (cifs vs. staging)

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

On Mon, Jan 12, 2009 at 01:23:07PM -0600, Steve French wrote:
> Is there some magic compile option alternative (other than renaming
> the function, which may be ok, since others probably don't depend on
> it)?  MD5Init is used outside fs/cifs/md5.c so can't be static

No, you should rename it to cifs_md5init to show that it is only for the
cifs module to use.  Try not to polute the global namespace with generic
function names.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/