Re: Linux killed Kenny, bastard!

From: KOSAKI Motohiro
Date: Tue Jan 13 2009 - 11:36:45 EST


Hi

sorry... I also don't like this patch.


> @@ -263,6 +270,15 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
> }
> } while_each_thread(g, p);
>
> + /*
> + * We did not find the process with requested string in its name,
> + * so lets search for the usual victim.
> + */
> + if (name && !chosen) {
> + name = NULL;
> + goto again;
> + }
> +
> return chosen;

this patch makes oom handling slower.
slow bad process selection cause next another out of memory.

then, your trouble become large.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/