Re: [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir

From: Paul Menage
Date: Tue Jan 13 2009 - 22:06:13 EST


On Tue, Jan 13, 2009 at 7:00 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
>
> Hmm, add wait_queue to css and wake it up at css_put() ?
>
> like this ?
> ==
> __css_put()
> {
> if (atomi_dec_return(&css->refcnt) == 1) {
> if (notify_on_release(cgrp) {
> .....
> }
> if (someone_waiting_rmdir(css)) {
> wake_up_him().
> }
> }
> }

Yes, something like that. A system-wide wake queue is probably fine though.

> pre_destroy() is for that. Now, If there are still references from "page"
> after pre_destroy(), it's bug.

OK.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/