Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes

[Joe Perches]

On Tue, 2009-01-13 at 12:54 -0800, Andrew Morton wrote:
> akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/filemap.c 
> Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
> Hugh Dickins <hugh@xxxxxxxxxxx>
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Miklos Szeredi <mszeredi@xxxxxxx>
> Nick Piggin <npiggin@xxxxxxx>
> 
> I think Balbir would be surprised!

get_maintainer output is in alphabetical order,
not ordered by signer frequency.

Balbir Singh is one of the top 5 signers over the last year
for mm/filemap.c excluding you and Linus.

$ git log --since=1-year-ago mm/filemap.c | \
	grep -P "^ +.*by:" | sort | uniq -c | sort -rn | head
     38     Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
     35     Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
     14     Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
      5     Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
      5     Signed-off-by: Hugh Dickins <hugh@xxxxxxxxxxx>
      4     Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
      4     Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>

> My script generates what I consider to be better results:
> 
> akpm:/usr/src/25> who-maintains.sh mm/filemap.c
> Nick Piggin <npiggin@xxxxxxx>
> Hugh Dickins <hugh@xxxxxxxxxxx>
> Fengguang Wu <wfg@xxxxxxxxxxxxxxxx>
> Christoph Hellwig <hch@xxxxxx>
> Steven Whitehouse <swhiteho@xxxxxxxxxx>
> Zach Brown <zach.brown@xxxxxxxxxx>
> Miklos Szeredi <mszeredi@xxxxxxx>
> Jan Kara <jack@xxxxxxx>
> Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
> Badari Pulavarty <pbadari@xxxxxxxxxx>
> 
> For some (git related) reason it is vastly slower than yours.

I think the major reason is your script is using all git history.
get_maintainer.pl is using just the last calendar year.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/