Re: [PATCH v2] memcg: fix section mismatch

From: KAMEZAWA Hiroyuki
Date: Wed Jan 14 2009 - 02:09:22 EST


On Wed, 14 Jan 2009 15:04:32 +0800
Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> At system boot when creating the top cgroup, mem_cgroup_create() calls
> enable_swap_cgroup() which is marked as __init, so mark mem_cgroup_create()
> as __ref to avoid false section mismatch warning.
>
> Reported-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

Acked-by; KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

> ---
>
> use __ref instead of __init_refok
>
change log ?

> ---
> mm/memcontrol.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index e2996b8..e57afca 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2181,7 +2181,7 @@ static void __init enable_swap_cgroup(void)
> }
> #endif
>
> -static struct cgroup_subsys_state *
> +static struct cgroup_subsys_state * __ref
> mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
> {
> struct mem_cgroup *mem, *parent;
> --
> 1.5.4.rc3
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/