Re: [PATCH -tip] nubus.h: extern's make no sense in userspace

[Harvey Harrison]

On Wed, 2009-01-14 at 21:10 +0100, Sam Ravnborg wrote:
> On Wed, Jan 14, 2009 at 12:04:21PM -0800, Harvey Harrison wrote:
> > 
> > I had a look at this file, there's the small patch that just wraps the whole
> > section of function declarations with ifdef __KERNEL, or the larger patch
> > that does the wrapping _and_ adds the missing externs to make it obvious.
> > 
> > But I'm not sure that there is agreement regarding adding the externs too.
> > 
> > What do people think?
> 
> The general consensus is to add externs for new prototypes.
> So if _and only if_ you are anyway touching this file in that area then
> I would say - add the externs. But just adding externs are not (yet)
> worth a patch alone.
> 

Agreed about just adding externs not being worth it, but as part of auditing
this file for userspace inclusion I'll send the patch that adds the externs
as well as the ifdef __KERNEL__ bits.


Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/