Re: [RFC][PATCH 5/4] memcg: don't call res_counter_uncharge whenobsolete

[KAMEZAWA Hiroyuki]

On Wed, 14 Jan 2009 19:25:39 +0530
Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> * Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> [2009-01-14 17:51:21]:
> 
> > This is a new one. Please review.
> > 
> > ===
> > From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
> > 
> > mem_cgroup_get ensures that the memcg that has been got can be accessed
> > even after the directory has been removed, but it doesn't ensure that parents
> > of it can be accessed: parents might have been freed already by rmdir.
> > 
> > This causes a bug in case of use_hierarchy==1, because res_counter_uncharge
> > climb up the tree.
> > 
> > Check if the memcg is obsolete, and don't call res_counter_uncharge when obsole.
> > 
> > Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
> 
> I liked the earlier, EBUSY approach that ensured that parents could
> not go away if children exist. IMHO, the code has gotten too complex
> and has too many corner cases. Time to revisit it.
> 

But I don't like -EBUSY ;)

When rmdir() returns -EBUSY even if there are no (visible) children and tasks,
our customer will take kdump and send it to me "please explain this kernel bug"

I'm sure it will happen ;)

-Kame



> -- 
> 	Balbir
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/