Re: [patch 2.6.29-rc] regulator: add get_status()

From: David Brownell
Date: Thu Jan 15 2009 - 10:35:52 EST


On Thursday 15 January 2009, Liam Girdwood wrote:
>
> > > +   /* report regulator status ... most other accessors report
> > > +    * control inputs, this reports results of combining inputs
> > > +    * from Linux (and other sources) with the actual load.
> > > +    */
> > > +   int (*get_status)(struct regulator_dev *);
> > > +
> >
> > ...this needs kerneldoc adding.
>
> Please send a separate patch for the kerneldoc as I've already applied.

So that will be the first member of "struct regulator_ops" to
grow kerneldoc ... out of a total of fifteen (now) members.
Hmm...

Maybe I'm not understanding what's meant by "kerneldoc adding".
Perhaps it's nothing more than a sentence resembling "returns
REGULATOR_STATUS_* code or negative errno", and not real
kerneldoc?

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/