Re: 2.6.28-rc9 panics with crashkernel=256M while booting

From: Chandru
Date: Fri Jan 16 2009 - 07:36:49 EST


On Thursday 15 January 2009 13:35:27 Chandru wrote:
> Hello Dave, From the debug console output, if there is anything you can add
> here, pls let me know.

As we can see from the console output here, physbase isn't page aligned when
the panic occurs. So we could as well send (start_pfn << PAGE_SHIFT) to
reserve_bootmem_node() instead of physbase. your thoughts ?.

Also end_pfn in mark_reserved_region_for_nid() is defined as

unsigned long end_pfn = ((physbase + size) >> PAGE_SHIFT);

Does this refer to the pfn after the area that we are interested in ?. We have
atleast two fixes here,
1. Limit start and end to bdata->node_min_pfn and bdata->node_low_pfn in
reserve_bootmem_node() and add comments out in there that the caller of the
funtion should be aware of how much are they reserving.
2. send (start_pfn << PAGE_SHIFT) to reserve_bootmem_node() instead of
physbase.

Chandru
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/