Re: [git patches] libata fixes

From: Alan Cox
Date: Fri Jan 16 2009 - 13:22:28 EST


> > + for (i = 0; i < 2; i++)
>
> s/2/ARRAY_SIZE/

It's 2. It's always 2 for a SFF controller. ARRAY_SIZE is just confusing
in this case as the array won't change size.


> There's a 64-bit divide in there. Will it link on 32-bit platforms?
> Or is this all 64-bit-only code?
>
> wtf is an octeon anyway? (greps). Some MIPS thing. I guess it's
> 64-bit-only.

Board specific driver anyway

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/