Re: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1

[Grant Grundler]

On Fri, Jan 16, 2009 at 9:09 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
...
>> +             CHIPREG_WRITE32(&ioc->chip->Doorbell, 0xC0FFEE00);
>> +             panic("%s: Firmware is halted due to command timeout\n",
>> +                     ioc->name);
>> +     }
>> +}
>> +EXPORT_SYMBOL(mpt_halt_firmware);
>
> Doing a panic() after we've already detected an error is plain nasty.
> Is there no way in which we can allow the kernel to continue?

Basically what James said. It's not long though: only 6 emails.
I started that thread thinking the same thing you did:
    http://marc.info/?t=123123569200003&r=1&w=2

TBH, I still wouldn't implement it the way LSI maintainers did.
I'm happy they are the maintainers and it's their call.

grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/