Re: [regression] hp-wmi: hangs system on boot

[Larry Finger]

Frans Pop wrote:
> On Saturday 17 January 2009, Frans Pop wrote:
>> When I first booted .29-rc2 my HP 2510p notebook hung while loading
>> hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed.
> 
> Reverting the following commit fixes the problems:
> 
> commit fe8e4e039dc3680681bf51af097af391f87038f8
> Author: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Date:   Fri Jan 9 16:40:54 2009 -0800
> 
>     hp-wmi: handle rfkill_register() failure

Ooops. There was a missing if statement. This one should fix it.


Index: linux-2.6/drivers/platform/x86/hp-wmi.c
===================================================================
--- linux-2.6.orig/drivers/platform/x86/hp-wmi.c
+++ linux-2.6/drivers/platform/x86/hp-wmi.c
@@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(stru
 		bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set;
 		bluetooth_rfkill->user_claim_unsupported = 1;
 		err = rfkill_register(bluetooth_rfkill);
+		if (err)
 			goto register_bluetooth_error;
 	}


-------



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/