Re: [git patches] libata hibernation fixes

From: Frans Pop
Date: Sun Jan 18 2009 - 05:20:28 EST


Rafael J. Wysocki wrote:
> There is a name conflict with a change applied after this patchset had
> been created. ÂThe appended patch fixes it for me.
[...]
> @@ -483,7 +483,7 @@ const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list)
> const struct dmi_system_id *d;
>
> for (d = list; d->ident; d++)
> - if (dmi_match(d))
> + if (dmi_matches(d))
> return d;

I get two warnings when compiling your patch with this correction on top:
drivers/firmware/dmi_scan.c: In function âdmi_first_matchâ:
drivers/firmware/dmi_scan.c:488: warning: return discards qualifiers from pointer target type
drivers/firmware/dmi_scan.c:483: warning: unused variable âiâ

The second is trivial, but the first is beyond me :-/

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/