Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c

[Sergei Shtylyov]

Hello.

Alan Cox wrote:

> > > I'm afraid you are the one who is wrong. The IDE layer is duplicating a
> > > generic level of indirection with its own code - purely because IDE
> > > pre-dates that core functionality. The whole IDE layer indirection can go
> > > away because Linux has caught up with the needs of the IDE layer.
> > >       
> >     What IDE indirection you're talking about anyway?
> >     
>
> As I said earlier ide_mm_inb etc via the function pointers tf_inb/tf_outb
> etc.
>   

  Ah... at least they don't have additional address checks that 
ioread*()/iowrite*() have...

> Given how small those functions are it might even be worth rolling them
> into two different versions of the functions like ide_tf_read as surely
> it costs more to call them (in size) than to inline the two for those
> functions?
>   

  Indeed.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/