Re: [RFC] Regulator: Push lock out of _notifier_call_chain + addvoltage change event.

From: Liam Girdwood
Date: Tue Jan 20 2009 - 15:09:22 EST


On Mon, 2009-01-19 at 18:20 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jic23@xxxxxxxxx>
> Regulator: Push lock out of _notifier_call_chain and into caller functions
> (side effect of fixing deadlock in regulator_force_disable)
> + Add a voltage changed event.
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>
>
> ---
> Follow up to Mark Brown's suggestion of moving the regulator lock out
> of the notifier code. This avoids cases where it was previously necessary
> to unlock the regulator before notification occured.
>
> Any scenarios where this will cause trouble?
>
> I'll do a documentation patch when we've pinned down how to do this.
> + can break the patch into one for pushing the lock out and one for
> adding the event.
>
> drivers/regulator/core.c | 15 ++++++++++-----
> drivers/regulator/wm8350-regulator.c | 2 ++
> drivers/regulator/wm8400-regulator.c | 2 +-
> include/linux/regulator/consumer.h | 2 ++
> 4 files changed, 15 insertions(+), 6 deletions(-)
>

Applied and fixed trailing white space.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/