Re: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers

From: Oliver Neukum
Date: Tue Jan 20 2009 - 18:28:30 EST


Am Wednesday 21 January 2009 00:17:18 schrieb Arnd Bergmann:
> > +       buffer = kmalloc(size, GFP_NOIO);
>
> GFP_NOIO seems out of place in a network driver: there is nothing
> wrong with waiting for I/O here, so plain GFP_KERNEL should be fine.

What happens if you run nfs over that link?

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/