Re: [PATCH 6/6] omap2 iommu: entries for Kconfig and Makefile

From: Hiroshi DOYU
Date: Thu Jan 22 2009 - 10:02:50 EST


Hi Russell,

From: "ext Russell King - ARM Linux" <linux@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] omap2 iommu: entries for Kconfig and Makefile
Date: Sat, 17 Jan 2009 16:59:20 +0000

> On Fri, Jan 16, 2009 at 10:37:35AM +0200, Hiroshi DOYU wrote:
> > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
> > ---
> >
> > arch/arm/mach-omap2/Makefile | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index bbd12bc..443e71f 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -24,6 +24,11 @@ endif
> > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o
> > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o
> >
> > +obj-$(CONFIG_OMAP_IOMMU) += iommu2.o
> > +ifeq ($(CONFIG_ARCH_OMAP3),y)
> > +obj-$(CONFIG_OMAP_IOMMU) += omap3-iommu.o
> > +endif
> > +
>
> I can see this expanding still further... so what about nipping it now
> before it gets out of hand:
>
> iommu-y += iommu2.o
> iommu-$(CONFIG_ARCH_OMAP3) += omap3-iommu.o
>
> obj-$(CONFIG_OMAP_IOMMU) += $(iommu-y)

Much simpler. Thanks. The updated one is attached.