Re: [PATCH] SLUB: revert direct page allocator pass through

From: Pekka Enberg
Date: Fri Jan 23 2009 - 11:07:29 EST


On Sat, 2009-01-24 at 02:37 +1100, Nick Piggin wrote:
> > > However, I don't know if netperf udp 4K over loopback is totally
> > > realistic. Maybe real network drivers have different allocation patterns.
> > > If I were you I wouldn't be too hasty to make big changes based on that
> > > alone, if it could introduce regression in somewhere more important.

On Saturday 24 January 2009 02:44:28 Pekka Enberg wrote:
> > Yup, I'm putting it in linux-next to see if anything pops up. It's of
> > course possible that it will introduce regression somewhere but seeing
> > the hit SLUB is taking from the page allocator, I'm bound to think that
> > performance increase claims of commit
> > aadb4bc4a1f9108c1d0fbd121827c936c2ed4217 ("SLUB: direct pass through of
> > page size or higher kmalloc requests") don't hold anymore.

On Sat, 2009-01-24 at 02:54 +1100, Nick Piggin wrote:
> Well what workload were they relating to? That could easily be retested.

No idea. I'm not sure I even reviewed that patch as it went in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/