Re: [PATCH 09/10] HID: add compat support

[Jaswinder Singh Rajput]

On Sun, 2009-01-25 at 17:57 +0100, Jiri Kosina wrote:
> On Sat, 24 Jan 2009, Jaswinder Singh Rajput wrote:
> 
> > This leads to 3 headers_check warnings:
> > 
> >  usr/include/linux/hid.h:66: leaks CONFIG_HID to userspace where it is not valid
> >  usr/include/linux/hid.h:69: extern's make no sense in userspace
> >  usr/include/linux/hid.h:76: extern's make no sense in userspace
> > 
> > So I  am moving whole above block in #ifdef __KEREL__
> > 
> > If you have any objections, then let me know, now it will look like this:
> > 
> >  #endif /* HID_FF */
> > 
> > +#ifdef __KERNEL__
> >  #ifdef CONFIG_HID_COMPAT
> >  #define HID_COMPAT_LOAD_DRIVER(name)   \
> >  /* prototype to avoid sparse warning */        \
> > @@ -804,6 +805,7 @@ EXPORT_SYMBOL(hid_compat_##name)
> >         extern void hid_compat_##name(void);    \
> >         hid_compat_##name();                    \
> >  } while (0)
> > +#endif /* __KERNEL__ */
> > 
> >  #endif
> 
> Thanks for catching this. Could you please resend the patch to me, with 
> proper changelog and Signed-off-by: line? Thanks.
> 

I have already send the patchset to Ingo "Re: [GIT PULL -tip] fix 22
make headers_check - 200901" and I also CCed to you jirislaby@xxxxxxxxx

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/