Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel][PATCH] orinoco: checkpatch cleanup)

From: Andy Whitcroft
Date: Mon Jan 26 2009 - 03:38:41 EST


On Mon, Jan 26, 2009 at 07:13:36AM +0300, Andrey Borzenkov wrote:
> On 26 ÑÐÐÐÑÑ 2009 06:46:02 Pavel Roskin wrote:
> >
> > Please run the patch itself through checkpatch. It finds two errors:
> >
> > ERROR: trailing statements should be on next line
> > #163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
> > + printk(stuff); } while (0)
> > + printk(stuff); } while (0)
>
> I ran "checkpatch --file hermes.c" after editing it and it found zero
> errors.
>
> Cc checkpatch maintainer.

Hmmm. Could I have the patch and the file either before or after
application please.

Very strange.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/