Re: [PATCH] x86: Fix setion mismatch warning.

From: Ingo Molnar
Date: Mon Jan 26 2009 - 08:29:20 EST



* Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:

> Impact: Fix section mismatch warning.
>
> Here function vmi_activate calls a init function activate_vmi , which
> causes the following section mismatch warnings. This patch fixes it.
>
> LD arch/x86/kernel/built-in.o
> WARNING: arch/x86/kernel/built-in.o(.text+0x13ba9): Section mismatch
> in reference from the function vmi_activate() to the function
> .init.text:vmi_time_init()
> The function vmi_activate() references
> the function __init vmi_time_init().
> This is often because vmi_activate lacks a __init
> annotation or the annotation of vmi_time_init is wrong.
>
> WARNING: arch/x86/kernel/built-in.o(.text+0x13bd1): Section mismatch
> in reference from the function vmi_activate() to the function
> .devinit.text:vmi_time_bsp_init()
> The function vmi_activate() references
> the function __devinit vmi_time_bsp_init().
> This is often because vmi_activate lacks a __devinit
> annotation or the annotation of vmi_time_bsp_init is wrong.
>
> WARNING: arch/x86/kernel/built-in.o(.text+0x13bdb): Section mismatch
> in reference from the function vmi_activate() to the function
> .devinit.text:vmi_time_ap_init()
> The function vmi_activate() references
> the function __devinit vmi_time_ap_init().
> This is often because vmi_activate lacks a __devinit
> annotation or the annotation of vmi_time_ap_init is wrong.
>
>
> Thanks.
>
> Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>

applied to tip/x86/urgent, thanks Rakib.

Note, the patch was corrupted here:

> +void __init vmi_activate(void)
> {
> unsigned long flags;
> --

that's too short - context diffs have 3 closing lines. I fixed this up
manually.

I also fixed the typo in the subject line.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/