Re: tty: tty_open can return to userspace holding tty_mutex

From: Alan Cox
Date: Mon Jan 26 2009 - 16:16:54 EST


On Mon, 26 Jan 2009 16:02:40 -0500
Eric Paris <eparis@xxxxxxxxxx> wrote:

> __tty_open could return (to userspace) holding the tty_mutex thanks to a
> regression introduced by 4a2b5fddd53b80efcb3266ee36e23b8de28e761a. This was
> found by bisecting an fsfuzzer problem. Admittedly I have no idea how it
> managed to tickle this 100% reliably, but it is clearly a regression and
> when hit leaves the box in a completely unusable state. This patch lets
> the fsfuzzer test complete every time.

Well spotted, and will go fix now. I think your fsfuzzer created a device
node for an out of range tty subdevice
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/