Re: [patch 016/104] epoll: introduce resource usage limits

[Bron Gondwana]

On Tue, 27 Jan 2009 22:57 -0800, "Davide Libenzi" <davidel@xxxxxxxxxxxxxxx> wrote:
> On Tue, 27 Jan 2009, Davide Libenzi wrote:
> 
> > Or, like Willy said, make (for -stable) the default unlimited, and 
> > let sysadmins to put the bounds if they feel the DoS can apply to them.
> 
> Whose patch follows ...

ACK.

Solves my problem and my "advocate of the poor suffering sysadmins who
have to track down why their stuff suddenly broke with a stable update
hat" problem as well.

One wondering...

> -       if (unlikely(atomic_read(&user->epoll_devs) >=
> -                       max_user_instances))
> +       if (atomic_read(&user->epoll_devs) >= max_user_instances)
>  		goto free_uid;

Any reason this has become _less_ unlikely()?

Thanks,

Bron.


-- 
  Bron Gondwana
  brong@xxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/