Re: [PATCH 3 of 7] x86: fix paravirt clobber in entry_64.S

From: Jeremy Fitzhardinge
Date: Thu Jan 29 2009 - 04:28:17 EST


Rusty Russell wrote:
On Thursday 29 January 2009 09:05:03 Jeremy Fitzhardinge wrote:
The clobber is trying to say that anything except RDI is available for
clobbering, but actually clobbers everything. This hasn't mattered
because the clobbers were basically ignored, but subsequent patches
will rely on them.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Hmm, did we never have the deliberate-clobbering debug code for 64 bit?

No. I think I killed it off before 64-bit was even started. There was some confusion about whether the return regs were considered to be "clobbered" or not, but I don't remember the details.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/