Re: [PATCH 2/6] integrity: IMA as an integrity service provider

From: James Morris
Date: Fri Jan 30 2009 - 04:06:06 EST


On Thu, 29 Jan 2009, Mimi Zohar wrote:

> +static struct ima_queue_entry *ima_lookup_digest_entry(u8 *digest_value)
> +{
> + struct ima_queue_entry *qe, *ret = NULL;
> + unsigned int key;
> + struct hlist_node *pos;
> +
> + key = ima_hash_key(digest_value);
> + rcu_read_lock();
> + hlist_for_each_entry_rcu(qe, pos, &ima_htable.queue[key], hnext) {
> + if (memcmp(qe->entry->digest, digest_value, 20) == 0) {

Minor issue: '20' should be IMA_DIGEST_SIZE, right?


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/