Re: 2.6.29-rc3: tg3 dead after resume

[Rafael J. Wysocki]

On Saturday 31 January 2009, Ingo Molnar wrote:
> 
> * Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> 
> > +static struct dev_pm_ops pcie_portdrv_pm_ops = {
> > +	.suspend = pcie_port_device_suspend,
> > +	.resume = pcie_port_device_resume,
> > +	.freeze = pcie_port_device_suspend,
> > +	.thaw = pcie_port_device_resume,
> > +	.poweroff = pcie_port_device_suspend,
> > +	.restore = pcie_port_device_resume,
> > +};
> 
> pet peeve: could we please use vertical spaces wherever they improve the 
> code?
> 
> Something like:
> 
> static struct dev_pm_ops pcie_portdrv_pm_ops = {
> 	.suspend	= pcie_port_device_suspend,
> 	.resume		= pcie_port_device_resume,
> 	.freeze		= pcie_port_device_suspend,
> 	.thaw		= pcie_port_device_resume,
> 	.poweroff	= pcie_port_device_suspend,
> 	.restore	= pcie_port_device_resume,
> };
> 
> ... and it all becomes clear at a glance. Please?

OK

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/