Re: [PATCH tip 1/3] trace: better manage the context info forevents

From: Arnaldo Carvalho de Melo
Date: Tue Feb 03 2009 - 08:15:36 EST


Em Mon, Feb 02, 2009 at 09:32:51PM -0500, Steven Rostedt escreveu:
> On Tue, 3 Feb 2009, Frederic Weisbecker wrote:
> > Now that I see the practical case, I'm not sure the design of my patch was valuable.
> > A tracer has to play with the flag if it wants to override the context info in
> > the bin/raw/hex cases. And I don't think this is a good way to proceed.
> >
> > In my opinion, the ITER_CONTEXT_INFO flag should mostly be set by the user.
>
> I think it should _only_ be set by user.

So we need a trace_event->binary_and_I_mean_it() callback that even if
the user wants, doesn't prints an ascii formatted context, as, for
tracers such as blkftrace, the binary trace has the context... in binary
:-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/