Re: [PATCH 2/2 RESEND] platform: introduce module id table forplatform devices

From: Greg KH
Date: Tue Feb 03 2009 - 20:29:17 EST


On Mon, Feb 02, 2009 at 06:11:48PM +0800, Eric Miao wrote:
> >
> > surely you mean PLATFORM_NAME_SIZE in this struct?
>
> Indeed, patch updated below (and as attached):

With this patch, I get the following warning:
drivers/base/platform.c:598: warning: assignment discards qualifiers from pointer target type

Also, don't put platform_match_id() underneath the comments for
platform_match(), that will only confuse the kernel-doc scripts and any
developer looking at the code.

Care to fix it up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/