Re: [RFC][PATCH] release mmap_sem before starting migration (WasRe: Need to take mmap_sem lock in move_pages.

From: KAMEZAWA Hiroyuki
Date: Wed Feb 04 2009 - 20:16:28 EST


On Wed, 4 Feb 2009 10:39:19 -0500 (EST)
Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 4 Feb 2009, KAMEZAWA Hiroyuki wrote:
>
> > mmap_sem can be released after page table walk ends.
>
> No. read lock on mmap_sem must be held since the migrate functions
> manipulate page table entries. Concurrent large scale changes to the page
> tables (splitting vmas, remapping etc) must not be possible.
>
Just for clarification:

1. changes in page table is not problem from the viewpoint of kernel.
(means no panic, no leak,...)
2. But this loses "atomic" aspect of migration and will allow unexpected
behaviors.
(means the page-mapping status after sys_move may not be what user expects.)


Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/