Re: [PATCH] PCI: add missing KERN_* constants to printks

From: Greg KH
Date: Thu Feb 05 2009 - 12:29:21 EST


On Thu, Feb 05, 2009 at 06:25:42PM +0100, Frank Seidel wrote:
> From: Frank Seidel <frank@xxxxxxxxxxx>
>
> According to kerneljanitors todo list all printk calls (beginning
> a new line) should have an according KERN_* constant.
> Those are the missing pieces here for the pci subsystem.
>
> Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx>
> ---
> drivers/pci/hotplug/pciehp_core.c | 6 +++---
> drivers/pci/hotplug/shpchp_core.c | 4 ++--
> drivers/pci/intel-iommu.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> --- a/drivers/pci/hotplug/pciehp_core.c
> +++ b/drivers/pci/hotplug/pciehp_core.c
> @@ -526,16 +526,16 @@ static int __init pcied_init(void)
>
> pciehp_firmware_init();
> retval = pcie_port_service_register(&hpdriver_portdrv);
> - dbg("pcie_port_service_register = %d\n", retval);
> + dbg(KERN_DEBUG "pcie_port_service_register = %d\n", retval);

dbg() already sets the KERN_ level, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/