3c509 resume from hibernation broken somewhere between 2.6.25 and 2.6.28

From: Ondrej Zary
Date: Fri Feb 06 2009 - 08:22:32 EST


Hello,
last year, I posted a patch which fixed hibernation on 3c509 cards. That was
back in 2.6.24. It worked fine in 2.6.25. But then I stopped using
hibernation (as it did not work with my new IT8212 RAID controller).

Now I fixed it and noticed that 3c509 does not wake up properly anymore (in
2.6.28) - neither in PnP nor in ISA modes. ifconfig down/up makes the card
work again in PnP mode. However, in ISA mode, ifconfig up ends with "No such
device" error.

Comparing the 3c509 driver between 2.6.25 and 2.6.28, there's only some
statistics-related change. So the cause of the problem must be somewhere
else.

This patch makes the resume work in PnP mode, but it's still not enough for
ISA mode.

--- linux-2.6.28-orig/drivers/net/3c509.c 2009-01-02 17:19:07.000000000 +0100
+++ linux/drivers/net/3c509.c 2009-02-05 22:36:20.000000000 +0100
@@ -1477,6 +1477,7 @@
spin_lock_irqsave(&lp->lock, flags);

outw(PowerUp, ioaddr + EL3_CMD);
+ EL3WINDOW(0);
el3_up(dev);

if (netif_running(dev))

--
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/