Re: [PATCH tip 2/2] tracing: Introducetrace_buffer_{lock_reserve,unlock_commit}

[Steven Rostedt]

On Sun, 8 Feb 2009, Frederic Weisbecker wrote:
> 
> 
> Ok, yes by making the flags per tracer, it will goes well.
> Just one thing, the insertion of an event is sometimes a hot path
> like with the functions tracer. And such facility adds some unused function calls
> and branch checking.
> But on such cases, we can use directly the ring buffer functions :-)

Yes, please keep the direct calls to the ring buffer on the function 
tracer. The function tracer is also special, in that if we have dynamic 
tracing turned on, we can simply point to a different function that does 
different things depending on trace settings.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/