/proc/profile broken on UP machines in 2.6.29-rc3

From: Lennert Buytenhek
Date: Mon Feb 09 2009 - 09:51:20 EST


I'm about 130k emails behind on my linux-kernel@ subscription, so I'm
not entirely sure whether this has been reported, but it seems that
profiling is broken on !CONFIG_SMP builds in 2.6.29-rc3.

It appears that since this commit:

commit c309b917cab55799ea489d7b5f1b77025d9f8462
Author: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Thu Jan 1 10:12:27 2009 +1030

cpumask: convert kernel/profile.c

there's no longer anything that sets any bits in prof_cpu_mask on
UP systems at all (the default was to assign CPU_MASK_ALL, and
profile_cpu_callback() which clears/sets bits at run time is only
built and registered on SMP builds), so the cpumask_test_cpu()
test in profile_tick() always fails, and no samples are ever counted.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/