Re: [Linux-fbdev-devel] [PATCH 8/15] stifb: check fb_alloc_cmapreturn value and handle failure properly

[Andres Salomon]

On Mon, 9 Feb 2009 18:05:49 +0100
Krzysztof Helt <krzysztof.h1@xxxxx> wrote:

> On Sat, 7 Feb 2009 12:15:06 -0500
> Andres Salomon <dilinger@xxxxxxxxxx> wrote:
> 
> > 
> > Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> > ---
> 
> Acked-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> I feel something is not right with the driver if memory 
> region (info->screen_base) is io mapped first then
> reserved with request_mem_region().
> 
> Regards,
> Krzysztof

Yeah, I noticed quite a few other bugs while going through cmap brokenness,
and I'm not even done w/ the cmap stuff yet.  I figured I'd do one thing at
a time.

Thanks for the Acks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/