Re: [Linux-fbdev-devel] [PATCH 14/15] amifb: check fb_alloc_cmapreturn value and handle failure properly

[Andres Salomon]

On Mon, 9 Feb 2009 21:26:29 +0100
Krzysztof Helt <krzysztof.h1@xxxxx> wrote:

> On Sat, 7 Feb 2009 12:18:57 -0500
> Andres Salomon <dilinger@xxxxxxxxxx> wrote:
> 
> > 
> > Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> > ---
> 
> Acked-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> One comment below.
[...]
> > @@ -2456,7 +2458,8 @@ amifb_error:
> >  
> >  static void amifb_deinit(void)
> >  {
> > -	fb_dealloc_cmap(&fb_info.cmap);
> > +	if (fb_info.cmap.len)
> > +		fb_dealloc_cmap(&fb_info.cmap);
> 
> Again, is the "if(fb_info.cmap.len)" needed here?

Yep; amifb_deinit is called from amifb_init in the case of errors.
This can happen before fb_alloc_cmap is called (but after the memory
region has been requested), so we need to explicitly check that cmap
memory has been allocated.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/