Re: [PATCH] mm fix page writeback accounting to fix oom conditionunder heavy I/O

[Linus Torvalds]

On Mon, 9 Feb 2009, Mathieu Desnoyers wrote:
> 
> So this patch fixes this behavior by only decrementing the page accounting
> _after_ the block I/O writepage has been done.

This makes no sense, really.

Or rather, I don't mind the notion of updating the counters only after IO 
per se, and _that_ part of it probably makes sense. But why is it that you 
only then fix up two of the call-sites. There's a lot more call-sites than 
that for this function. 

So if this really makes a big difference, that's an interesting starting 
point for discussion, but I don't see how this particular patch could 
possibly be the right thing to do.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/