Re: [PATCH 1/2] tracing/sysprof: add missingtracing_{start,stop}_record_cmdline()

[Steven Rostedt]

On Tue, 10 Feb 2009, Frederic Weisbecker wrote:

Hi Frederic!

Just a quick comment about the change log. I'm still learning how to
write them too, but I'll give my 2 cents anyway ;-)

When looking a logs, I sometimes like to know the reason for the change.
So below I would have also included...

> 
> --
> >From 97113f668e9aef7ba101fbb3399e5ebb27aeec4c Mon Sep 17 00:00:00 2001
> From: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Date: Tue, 10 Feb 2009 15:07:22 +0100
> Subject: [PATCH] tracing/sysprof: fix a build error on sysprof tracer
> 

The sysprof tracer gets the command line data from the context switch 
tracer. We must select it otherwise we get 

>  the following build error:
> 
> kernel/built-in.o: In function `stack_trace_reset':
> trace_sysprof.c:(.text+0x3e91a): undefined reference to `tracing_stop_cmdline_record'
> kernel/built-in.o: In function `stack_trace_init':
> trace_sysprof.c:(.text+0x3e953): undefined reference to `tracing_start_cmdline_record'
> 
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Just makes reading the logs a bit easier to see what is happening.

Thanks!

Acked-by: Steven Rostedt <srostedt@xxxxxxxxxx>

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/