Re: [patch 33/41] asus-laptop: Fix the led behavior with value > 1

From: Pavel Machek
Date: Tue Feb 10 2009 - 15:24:51 EST


On Wed 2009-02-04 10:46:54, Greg KH wrote:
> 2.6.27-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Corentin Chary <corentincj@xxxxxxxxxx>
>
> commit e3deda9c87ac5eef2b5d18cd0b5511370979ca26 upstream.
>
> Fix http://bugzilla.kernel.org/show_bug.cgi?id=11613 .
>
> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Cc: Thomas Renninger <trenn@xxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> ---
> drivers/misc/asus-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/misc/asus-laptop.c
> +++ b/drivers/misc/asus-laptop.c
> @@ -351,7 +351,7 @@ static void write_status(acpi_handle han
> static void object##_led_set(struct led_classdev *led_cdev, \
> enum led_brightness value) \
> { \
> - object##_led_wk = value; \
> + object##_led_wk = (value > 0) ? 1 : 0; \

"= !!value" is standard way to do that.... for unsigned value.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/