Re: [PATCH] xen: expose enable_IO_APIC for 32-bit

From: Yinghai Lu
Date: Wed Feb 11 2009 - 03:36:51 EST


On Mon, Feb 9, 2009 at 12:05 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> enable_IO_APIC() is defined for both 32- and 64-bit x86, so it should
> be declared for both.
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> ---
> arch/x86/include/asm/hw_irq.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
> index 1b82781..370e1c8 100644
> --- a/arch/x86/include/asm/hw_irq.h
> +++ b/arch/x86/include/asm/hw_irq.h
> @@ -65,9 +65,7 @@ extern void disable_IO_APIC(void);
> extern int IO_APIC_get_PCI_irq_vector(int bus, int slot, int fn);
> extern void setup_ioapic_dest(void);
>
> -#ifdef CONFIG_X86_64
> extern void enable_IO_APIC(void);
> -#endif
>
> /* Statistics */
> extern atomic_t irq_err_count;
> --
> 1.6.0.6
>
> --

wonder if we should call enable_IO_APIC in 32bit like 64bit...
should be ok.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/