Re: [PATCH 0/8] git pull request for tip/tracing/core

[Steven Rostedt]

On Wed, 11 Feb 2009, Steven Rostedt wrote:

> 
> On Wed, 11 Feb 2009, Ingo Molnar wrote:
> 
> > 
> > > > Steven Rostedt (7):
> > > >       ring-buffer: add NMI protection for spinlocks
> > > >       nmi: add generic nmi tracking state
> > 
> > hm, this commit breaks a number of non-x86 architectures the following way:
> > 
> > In file included from /home/mingo/tip/include/linux/interrupt.h:12,
> >                  from /home/mingo/tip/arch/ia64/include/asm/mca.h:16,
> >                  from /home/mingo/tip/arch/ia64/kernel/asm-offsets.c:17:
> > /home/mingo/tip/include/linux/hardirq.h:67:2: #error PREEMPT_ACTIVE too high!
> > make[2]: *** [arch/ia64/kernel/asm-offsets.s] Error 1

I just looked at alpha and arm, I'm now looking at ia64. And this could
be an issue, since it has 14 bits for hard irqs.

What would be the impact to make the preempt count a long?

-- Steve


> > 
> > Alpha and ARM are broken too. (and possibly others)
> 
> Looking at this, it doesn't seem like it should be a problem. Perhaps the 
> CPP is treating the number as signed. Does this patch fix the compile?
> 
> -- Steve
> 
> Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
> 
> diff --git a/include/linux/hardirq.h b/include/linux/hardirq.h
> index f3cf86e..9bd4302 100644
> --- a/include/linux/hardirq.h
> +++ b/include/linux/hardirq.h
> @@ -63,7 +63,7 @@
>  
>  #define NMI_OFFSET	(PREEMPT_ACTIVE << 1)
>  
> -#if NMI_OFFSET >= 0x80000000
> +#if NMI_OFFSET >= 0x80000000UL
>  #error PREEMPT_ACTIVE too high!
>  #endif
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/