Re: namespaces?: bug at mm/slub.c:2750

From: David Howells
Date: Wed Feb 11 2009 - 12:03:20 EST


Serge E. Hallyn <serue@xxxxxxxxxx> wrote:

> static void uid_hash_remove(struct user_struct *up)
> {
> + put_user_ns(up->user_ns);
> hlist_del_init(&up->uidhash_node);
> }

Don't you need to do the hlist_del_init() first? Otherwise, mightn't the
put_user_ns() cause the namespace to be freed before hlist_del_init() removes
the user_struct from it?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/