Re: [patch] x86, pat: fix warn_on_once() while mapping 0-1MB rangewith /dev/mem

From: Ingo Molnar
Date: Wed Feb 11 2009 - 15:09:59 EST



* Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:

> From: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
> Subject: x86, pat: fix warn_on_once() while mapping 0-1MB range
> with /dev/mem
>
> Jeff Mahoney reported:
> > With Suse's hwinfo tool, on -tip:
> > WARNING: at arch/x86/mm/pat.c:637 reserve_pfn_range+0x5b/0x26d()
>
> reserve_pfn_range() is not tracking the memory range below 1MB
> as non-RAM and as such is inconsistent with similar checks in
> reserve_memtype() and free_memtype()
>
> Rename the pagerange_is_ram() to pat_pagerange_is_ram() and add the
> "track legacy 1MB region as non RAM" condition.
>
> And also, fix reserve_pfn_range() to return -EINVAL, when the pfn
> range is RAM. This is to be consistent with this API design.
>
> Reported-and-tested-by: Jeff Mahoney <jeffm@xxxxxxxx>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
> ---

applied to tip:x86/urgent, thanks guys!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/