Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

From: Ed Cashin
Date: Wed Feb 11 2009 - 19:54:21 EST


On Wed, Feb 11, 2009 at 04:29:44PM -0800, Andrew Morton wrote:
> On Wed, 11 Feb 2009 19:16:44 -0500
> Ed Cashin <ecashin@xxxxxxxxxx> wrote:
>
> > The Welland ME-747K-SI AoE target generates unsolicited AoE
> > responses that are marked as vendor extensions. Instead of
> > ignoring these packets, the aoe driver was generating kernel
> > messages for each unrecognized response received. This patch
> > corrects the behavior.

...
> Do you believe that this fix should be backported into earlier kernel
> versions? (2.6.28.x, 2.6.27.x, etc)

It shouldn't hurt, it can help, and it's well tested.

I am not sure how many environments have AoE packets that have vendor
extension command types, though, so I can't gauge how pressing the
need is for backporting.

If the cost of backporting is low, it probably should be backported.

--
Ed Cashin <ecashin@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/