Re: [PATCH] sysfs: sysfs_add_one tells you _where_ the duplicatefile is

[Greg KH]

On Thu, Feb 12, 2009 at 10:05:23AM +0100, Kay Sievers wrote:
> On Thu, Feb 12, 2009 at 08:02, Alex Chiang <achiang@xxxxxx> wrote:
> 
> > sysfs: sysfs_add_one WARNs with full path to duplicate filename
> >
> > As a debugging aid, it can be useful to know the full path to a
> > duplicate file being created in sysfs.
> 
> >        ret = __sysfs_add_one(acxt, sd);
> > -       WARN(ret == -EEXIST, KERN_WARNING "sysfs: duplicate filename '%s' "
> > -                      "can not be created\n", sd->s_name);
> > +       if (ret == -EEXIST) {
> > +               char path[PATH_MAX];
> 
> Isn't that 4k on the stack, and a bit large to put there?

I agree, that's not ok.  Alex, care to redo this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/