Re: [PATCHv2 5/5] VFS: DazukoFS, stackable-fs, file access control

From: Eric W. Biederman
Date: Thu Feb 12 2009 - 15:24:27 EST


John Ogness <dazukocode@xxxxxxxxxx> writes:

> Patch 5: Creates /dev/dazukofs.ign as an (optional) mechanism for any
> processes to hide themselves from DazukoFS file access
> control.

Your reference counting is broken. What happens if a process exits
and you are ignoring it.

When fixing this use a struct pid * not struct task_struct *. That
is what struct pid is for there is no need to pin the entire task
struct into memory after the process exits just because
you decided to ignore it.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/